common: improve GGUF quantization tag regex#22164
Open
v1b3coder wants to merge 1 commit intoggml-org:masterfrom
Open
common: improve GGUF quantization tag regex#22164v1b3coder wants to merge 1 commit intoggml-org:masterfrom
v1b3coder wants to merge 1 commit intoggml-org:masterfrom
Conversation
Update the regex in get_gguf_split_info to better identify quantization tags, allowing for prefixes like 'UD-' in 'UD-Q8_K_XL'. This ensures models with these naming conventions are correctly parsed during download.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the GGUF quantization tag regex to correctly identify tags with prefixes.
Motivation
The previous regex
[-.]([A-Z0-9_]+)$was too simple and could fail to correctly identify quantization tags that include prefixes or specific patterns. For example, models likeunsloth/gemma-4-31B-it-GGUF:UD-Q8_K_XLuse tags likeUD-Q8_K_XL, which the previous regex might not have handled optimally or consistently across different naming conventions.The new regex
[-.]((?:[A-Z]+-)?[A-Z][0-9][A-Z0-9_]*)$allows for an optional uppercase prefix followed by a hyphen, ensuring that tags likeUD-Q8_K_XLare correctly captured as the quantization tag.