Open
Conversation
fiesh
force-pushed
the
fix-assertion-failure
branch
from
c41ea07 to
2237b3d
Compare
Author
|
This works, but I'm not certain if it's that great. It might also make sense to reduce code duplication by not repeating the assertion every time. But since that's the way it was originally, I wanted to keep the change minimal. I'd be grateful for somebody with better understanding of the code if the new assertion is correct or just hides a deeper issue. It does seem stable though. |
Having `tensor->data == NULL` and `tensor->view_src->data != NULL` is also a valid state that happens when `--parallel` is > 1. This closes ggml-org#19839.
fiesh
force-pushed
the
fix-assertion-failure
branch
from
2237b3d to
46031da
Compare
Author
|
(A minor thing -- I'd also greatly prefer not to use |
github-actions
bot
added
the
ggml
Contributor
|
Feels like a backend bug, why would |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertion check was too strong.
This closes #19839.