ngram-mod: Reset i_last when low acceptance streak occurs#22168
Open
treo wants to merge 1 commit intoggml-org:masterfrom
Open
ngram-mod: Reset i_last when low acceptance streak occurs#22168treo wants to merge 1 commit intoggml-org:masterfrom
treo wants to merge 1 commit intoggml-org:masterfrom
Conversation
By resetting i_last to zero, we will include the current context when rebuilding the speculative map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
By resetting i_last to zero, we will include the current context when rebuilding the speculative map.
The existing behavior would skip the current context, thereby often losing the benefit of speculative decoding during later parts of the generation.
The effect of this seems to depend on both the model and the speculation parameters.
Benchmark:
vllm bench serve --model google/gemma-4-26B-A4B-it --host 127.0.0.1 --port 9876 --num-prompts 96 --dataset-name hf --dataset-path vdaita/edit_5k_char --backend openai-chat --endpoint '/v1/chat/completions' --max-concurrency 1Gemma 4 26B-A4B:
Qwen 3.6 35B-A3B:
As we can see, the effect isn't huge but at 3% to 9% it is still measurable.
The price we pay for it is 1 line of code and a moment longer for speculative map repopulation whenever a low acceptance streak occours.
Requirements