whisper : reject audio too short for reflective padding#3925
Open
hellopahe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log_mel_spectrogramreflective-pads the start of the signal by copying the firstWHISPER_N_FFT/2samples back-to-front. That length is fixed, so anything shorter than the pad window reads off the end of the input buf.Fixes #3923
This PR goes with rejecting short input and returning false.
Added a small regression test, in which a couple of very short buffers get rejected and a just-long-enough one still goes through.
AI disclosure: claude code helped write the test.