fix: GitHub fetch caching#52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens
fetchLanguageData's caching behavior and fixes a bug inIGNORED_REPOScachedLanguageDataand served as truth for a full hour. Both now share one guard; a result is only cached when no source failed.fetchLanguageDataon a cold/expired cache each independently triggered a full repo-list + per-repo-languages crawl., now share a single in-flight promise.IGNORED_REPOS: previously matched by bare repo name only, so two sources (e.g. a user and an org) with a same-named repo couldn't be ignored independently. Now also acceptsowner/nameto scope an ignore to one source/languagescall was silently treated as "no languages" instead of a failure, unlike the repo-list fetch.