Fix legend colour overflow with palette-matched fallback colours#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Segments cycled colours with
colours[i % colours.length]but the legendindexed raw (
colours[i]), so any theme with fewer colours than therequested language count rendered
fill="undefined"whilesegments silently repeated colours.
Changes
resolveColour(in the renamedcharts/helpers.ts) as thesingle place both segments and legend resolve a colour for a given index.
resolveColournow generates anew colour instead of repeating: hue is spaced by the golden angle
(137.508°) for even visual separation, and saturation/lightness are
averaged from the active theme's own palette so generated colours match
its look rather than using a fixed guess.
github-top-languagesreference in package.json.