feat: onBeforeCellEdit hook for RowBasedEditing plugin

[zewa666]

provides the opportunity to define a callable hook to decide editor read/write on a per cell basis

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (e18dfa1) to head (02c6cd6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2646   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         200      200           
  Lines       25317    25325    +8     
  Branches     8951     8954    +3     
=======================================
+ Hits        25317    25325    +8     

Flag	Coverage Δ
angular	100.0% <ø> (ø)
universal	100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[zewa666]

the reason for this one is that the user might be using his own onBeforeEditCell event, which the plugin also defines. So since the broadcast isnt defining how the order of multiple modal results are handled, this way the user can define the event as a hook, being called by the plugin itself.

the use case is to allow individual users only edit specific cells, based on whatever criteria.

[pkg-pr-new]

angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2646

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2646

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2646

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2646

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2646

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2646

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2646

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2646

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2646

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2646

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2646

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2646

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2646

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2646

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2646

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2646

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2646

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2646

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2646

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2646

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2646

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2646

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2646

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2646

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2646

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2646

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2646

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2646

commit: 02c6cd6

[ghiscoding]

fine by me, can you run Prettier write to fix the formatting issue though... nevermind, it looks like it's fixed now. Thanks

[ghiscoding]

hey since you're online but on a completely different topic... 6pac just got introduced to AI and he's going wild with his new Claude Pro or Premium plan (170$/month), he's running Claude Fable to rewrite Freezing/Pinning with a different approach not using div I think (I'm not sure if it's worth it yet, but it would also add right pinning which we don't currently have and it wouldn't create all these viewports when not using freezing (which it currently does)). He also has another PR to add variable row height, but I told him to rethink this one since we can do better.... anyway, if you have some time and to review/comment on them, feel free to join the party. I told him that especially his freezing rewrite should be a major version on his repo and if I decide to go ahead with that too in here, that wouldn't be until my next major around January

check the last currently open PRs he created
https://github.com/6pac/SlickGrid/pulls

[zewa666]

oha, new-found power with more Tokens ... 🤣

thanks for letting me know. Variable row height would actually be one of the last limitations I know of and cant nicely work around. I'll check them out and add my comments if helpful

[ghiscoding]

great thanks, let's merge your PR and release around the end of this week.
Cheers and welcome back 😉