S3 requests tool#1
Open
giditietz wants to merge 2 commits into
Open
Conversation
| @@ -0,0 +1,226 @@ | |||
| import requests | |||
| import hashlib | |||
| import xml.etree.ElementTree as ET | |||
Collaborator
There was a problem hiding this comment.
Avoid this type of imports. It makes code unreadable - it's always better to refer to things within their namespace where possible. There are some exceptions to this rule, but generally:
import xml.etree
...
tree = xml.etree.ElementTree()
tree.do_something()
is just a lot more readable and doesn't constrain you to the imported module's names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple tool that wraps 'Requests', used for S3 testing.