Open
Conversation
- In Step 2: In the `withdraw()` function, it's better to use the `transfer()` method instead of `sendValue()` to transfer funds because the `transfer()` method has built-in checks to prevent re-entrancy attacks. - Added relevant comments to the code for better understanding. - Indented the code to make it look neat. - Corrected grammatical mistakes. - Did para-phrasing. - Added proper spacing between sentences for neatness of the document. - Added punctuations wherever, required.
- There is a minor issue with the use of the class attribute in the HTML tags which I have corrected. In JSX, which is a syntax extension of JavaScript used in React, the `class` attribute should be replaced with the `className` attribute. - Added relevant comments to the code. - Applied code indentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Step 2:
a) In the
withdraw()function, it's better to use thetransfer()method instead ofsendValue()to transfer funds because thetransfer()method has built-in checks to prevent re-entrancy attacks.Added relevant comments to the code for better understanding.
Indented the code to make it look neat.
Added relevant links.
Corrected grammatical mistakes.
Did para-phrasing.
Added proper spacing between sentences for neatness of the document.
Added punctuations wherever, required.
-In gallery.html:
a) There is a minor issue with the use of the class attribute in the HTML tags which I have corrected. In JSX, which is a syntax extension of JavaScript used in React, the
classattribute should be replaced with theclassNameattribute.