Skip to content

fix: scan pipeline performance + cross-platform installer + WSL/platform hardening#9

Merged
giggsoinc merged 2 commits into
mainfrom
fix/scan-pipeline-performance
Jun 2, 2026
Merged

fix: scan pipeline performance + cross-platform installer + WSL/platform hardening#9
giggsoinc merged 2 commits into
mainfrom
fix/scan-pipeline-performance

Conversation

@giggsoinc

Copy link
Copy Markdown
Owner

Summary

Consolidated, origin-controlled PR. Contains everything from the fork-based PRs #7 and #8 plus the additional cross-platform hardening fix that was missing from PR #8.

  • Scan pipeline performance: 158s → 0.01s on 113 repos (os.scandir + early pruning, replaces Path.rglob).
  • Agent installer: 36 cross-platform bug fixes (Windows / Mac / Linux) — setup_agent.ps1/sh.template.
  • scan_repo_discovery hardening (c7b4018, NOT on PR fix: scan pipeline performance — 158s → 0.01s on 113 repos #8):
    • Add missing import platform as _platform (P2)
    • WSL1 detection fallback via os.environ["WSL_DISTRO_NAME"] (P1)
    • Windows drive-type check error handling for WSL2 compat (P2)
    • Confirm macOS ~/.config/gcloud exclusion via absolute-path check (P1)

Supersedes

Test plan

🤖 Generated with Claude Code

SatishwaranM and others added 2 commits May 25, 2026 20:43
- scan_tools_code: replace Path.rglob with os.scandir + early pruning

- scan_repo_discovery: v2 multi-OS walker (6-rule algorithm, all drives)

- setup_agent.ps1: ExecutionTimeLimit PT2M to PT10M

- repo_discovery.yaml: updated config for v2 walker

- test fixes: encoding, MAX_PATH, new regression coverage

Tested: 22 unit tests pass, 355 full suite, e2e 3.06s on 113 repos
…ndling

- Add missing 'import platform as _platform' (P2)
- Add WSL1 detection fallback using os.environ.get('WSL_DISTRO_NAME') (P1)
- Improve Windows drive type check error handling for WSL2 compat (P2)
- Verify macOS gcloud exclusion via absolute path check (P1)

All 13 regression tests pass. Fixes #8 Raven feedback.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@giggsoinc giggsoinc merged commit c7b4018 into main Jun 2, 2026
1 of 4 checks passed
giggsoinc pushed a commit that referenced this pull request Jun 2, 2026
…ggso)

PR #9 original fixes (5):
- PowerShell param() block moved before ErrorActionPreference
- Removed A/B TEST debug header from scan_repo_discovery.py.frag
- Removed 63-line v1.0.0 rollback block from scan_repo_discovery.py.frag
- Corrected _REPO_MAX_SECONDS tunable comment
- Added multi-process safety NOTE to _catalog_lock in agent_store.py

PowerShell template hardening (8):
- 5x UTF-8 BOM fix: Set-Content replaced with Write-Utf8NoBom helper
- 2x depth fix: -Depth 4 to -Depth 6 to match _REPO_MAX_DEPTH=6
- 1x TmpMeta security: try/finally ensures OTP hash temp file always deleted

Full codebase audit via Raven Enterprise (shadow mode) - 133 issues resolved:
- 87 bare/broad except clauses annotated across frags, dashboard, src/
- 3 files refactored into sub-modules (hourly_rollup, rollup_reader, agent_store)
  New: _rollup_agg.py, _rollup_s3.py, _rollup_scheduler.py, _rollup_merge.py, _agent_otp.py
- 7 LOC-exempt files: architectural justification documented in source
- 4 test files: loc-exempt markers removed (policy: cap is production-only)
- 2 false-positive SECRET annotations added for AWS docs example keys
- Dead-marker and hack comments cleaned in chat/engine.py and chat/tools.py
- Fragment globals documented in scan_header.py.frag

Test results: 444 passed, 1 skipped, 0 failures
Integration errors: 14 pre-existing (require LocalStack, unrelated to changes)

Supersedes: PR #7, PR #8, PR #9
Reviewed by: Raven Enterprise (shadow mode) - Giggso Inc
Report: docs/full_fix_verification_report.pdf

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
giggsoinc added a commit that referenced this pull request Jun 2, 2026
fix: PR #9 review fixes + full codebase audit — reviewed by Raven (Giggso)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants