Fix usePortal#44
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default container property for the Portal component to a string literal ('body') instead of a direct reference to document.body to support future flexibility.
- Change the container property from a DOM reference to a string.
Comments suppressed due to low confidence (1)
src/components/Portal/usePortal.ts:108
- Ensure that the consuming code correctly handles a string value for the container property, as this change may affect functionality if a DOM element was previously expected. Consider updating type definitions or adding conversion logic as needed.
container: 'body',
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
src/components/Portal/usePortal.tsfile. Thecontainerproperty indefaultPropswas updated fromdocument.bodyto the string'body'for consistency and potential future flexibility.