Skip to content

Updates#111

Merged
gilbarbara merged 16 commits into
mainfrom
updates
Feb 22, 2026
Merged

Updates#111
gilbarbara merged 16 commits into
mainfrom
updates

Conversation

@gilbarbara
Copy link
Copy Markdown
Owner

@gilbarbara gilbarbara commented May 26, 2025

This pull request modernizes and improves the repository's continuous integration (CI) and documentation. It replaces legacy CI configurations with updated GitHub Actions workflows, introduces a new preview workflow, enhances documentation for both users and contributors (including a new architecture overview), and updates the demo environment setup.

CI/CD Workflow Updates:

  • Replaces the old .github/workflows/main.yml with a modular set of workflows:
    • Adds .github/workflows/ci.yml for validation and publishing, using updated Node and pnpm versions, and integrating SonarQube for code quality checks.
    • Adds .github/workflows/preview.yml to provide preview deployments on PRs and main branch pushes.
    • Removes the legacy .github/workflows/main.yml.
    • Removes the deprecated .codesandbox/ci.json config.

Documentation Improvements:

  • Significantly rewrites and expands the README.md:
    • Clarifies the library's purpose and features.
    • Improves usage instructions and customization examples.
    • Adds a detailed, organized props table and type definitions.
    • Enhances explanations of modes and styling options. [1] [2] [3] [4] [5] [6] [7] [8]
  • Adds a new CLAUDE.md file with contributor/developer guidance, including architecture, commands, and testing approach.

Demo Environment Updates:

  • Adds a new index.html for the demo app to improve local development and preview.
  • Updates demo environment configuration:
    • Adds .npmrc for hoisting and linking settings.
    • Adds ESLint configuration using a shared config.

These changes modernize the project's CI/CD, improve onboarding and usage documentation, and streamline demo development.

@gilbarbara gilbarbara requested a review from Copilot May 26, 2025 02:02
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented May 26, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented May 26, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

This comment was marked as outdated.

@gilbarbara gilbarbara force-pushed the updates branch 2 times, most recently from 6f6de06 to f53b669 Compare May 26, 2025 12:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces significant updates to improve the functionality, maintainability, and user experience of the react-floater library. The changes modernize the codebase with updated dependencies, enhanced testing patterns, and new customization features.

Key changes include:

  • Added custom arrow support via a new arrow prop for enhanced visual customization
  • Modernized React import patterns and hooks usage throughout the codebase
  • Updated testing approach with improved test utilities and consolidated snapshot testing
  • Enhanced documentation with better examples and comprehensive prop tables

Reviewed Changes

Copilot reviewed 21 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/index.spec.tsx Refactored tests with modern React imports, improved test utilities, and added custom arrow testing
test/snapshots/*.snap Updated snapshots to reflect structural changes in component output
test/fixtures/components.tsx Modernized React imports and component organization
src/types/common.ts Added arrow prop type definition and reorganized type structure
src/modules/hooks.ts Removed unused useSingleton hook
src/modules/helpers.ts Removed unused React import and isValidElement helper
src/index.tsx Major refactor with modern React hooks, improved effect management, and arrow prop support
src/components/*.tsx Updated all components with modern React imports and arrow prop integration
pnpm-workspace.yaml Added ESLint dependency hoisting configuration
package.json Updated dependencies to latest versions
demo/src/examples/*.tsx Enhanced examples with custom arrow demonstrations
README.md Comprehensive documentation improvements with better structure and examples
.github/workflows/main.yml Updated CI workflow with pnpm v10 and Node.js v22
Comments suppressed due to low confidence (1)

test/index.spec.tsx:30

  • [nitpick] The variable name idWrapper could be more descriptive. Consider renaming to wrapperId or wrapperTestId to better indicate its purpose as a test identifier.
const idWrapper = `${id}-wrapper`;

Comment thread test/index.spec.tsx Outdated
Comment thread src/index.tsx Outdated
Comment thread src/components/Floater/Arrow.tsx Outdated
- length to size
- spread to base
- fix eslint
- migrate to tsdown
- replace type-fest
- remove DOM checks
- update tests
@gilbarbara gilbarbara force-pushed the updates branch 4 times, most recently from 7ce5992 to 98b95e3 Compare February 17, 2026 02:37
- fix initialization
- remove tree-changes-hook
- add tests
- migrate to vite
- replace @gilbarbara/components with @heroui + tailwind
- remove broken codesandbox ci
Repository owner deleted a comment from pkg-pr-new Bot Feb 22, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 22, 2026

@gilbarbara gilbarbara merged commit 65fbae4 into main Feb 22, 2026
5 checks passed
@gilbarbara gilbarbara deleted the updates branch February 22, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants