Updates#111
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
6f6de06 to
f53b669
Compare
- update GH Actions workflow
- update tests
- update README
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces significant updates to improve the functionality, maintainability, and user experience of the react-floater library. The changes modernize the codebase with updated dependencies, enhanced testing patterns, and new customization features.
Key changes include:
- Added custom arrow support via a new
arrowprop for enhanced visual customization - Modernized React import patterns and hooks usage throughout the codebase
- Updated testing approach with improved test utilities and consolidated snapshot testing
- Enhanced documentation with better examples and comprehensive prop tables
Reviewed Changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/index.spec.tsx | Refactored tests with modern React imports, improved test utilities, and added custom arrow testing |
| test/snapshots/*.snap | Updated snapshots to reflect structural changes in component output |
| test/fixtures/components.tsx | Modernized React imports and component organization |
| src/types/common.ts | Added arrow prop type definition and reorganized type structure |
| src/modules/hooks.ts | Removed unused useSingleton hook |
| src/modules/helpers.ts | Removed unused React import and isValidElement helper |
| src/index.tsx | Major refactor with modern React hooks, improved effect management, and arrow prop support |
| src/components/*.tsx | Updated all components with modern React imports and arrow prop integration |
| pnpm-workspace.yaml | Added ESLint dependency hoisting configuration |
| package.json | Updated dependencies to latest versions |
| demo/src/examples/*.tsx | Enhanced examples with custom arrow demonstrations |
| README.md | Comprehensive documentation improvements with better structure and examples |
| .github/workflows/main.yml | Updated CI workflow with pnpm v10 and Node.js v22 |
Comments suppressed due to low confidence (1)
test/index.spec.tsx:30
- [nitpick] The variable name
idWrappercould be more descriptive. Consider renaming towrapperIdorwrapperTestIdto better indicate its purpose as a test identifier.
const idWrapper = `${id}-wrapper`;
- length to size - spread to base
- fix eslint - migrate to tsdown
- replace type-fest
- remove DOM checks - update tests
7ce5992 to
98b95e3
Compare
- fix initialization - remove tree-changes-hook - add tests
- migrate to vite - replace @gilbarbara/components with @heroui + tailwind
- remove broken codesandbox ci
|

This pull request modernizes and improves the repository's continuous integration (CI) and documentation. It replaces legacy CI configurations with updated GitHub Actions workflows, introduces a new preview workflow, enhances documentation for both users and contributors (including a new architecture overview), and updates the demo environment setup.
CI/CD Workflow Updates:
.github/workflows/main.ymlwith a modular set of workflows:.github/workflows/ci.ymlfor validation and publishing, using updated Node and pnpm versions, and integrating SonarQube for code quality checks..github/workflows/preview.ymlto provide preview deployments on PRs and main branch pushes..github/workflows/main.yml..codesandbox/ci.jsonconfig.Documentation Improvements:
README.md:CLAUDE.mdfile with contributor/developer guidance, including architecture, commands, and testing approach.Demo Environment Updates:
index.htmlfor the demo app to improve local development and preview..npmrcfor hoisting and linking settings.These changes modernize the project's CI/CD, improve onboarding and usage documentation, and streamline demo development.