Implementation of Trigger module for RDF + Minor fix + Fix in Snapshot#10
Open
BlancoFS wants to merge 9 commits intogiorgiopizz:masterfrom
Open
Implementation of Trigger module for RDF + Minor fix + Fix in Snapshot#10BlancoFS wants to merge 9 commits intogiorgiopizz:masterfrom
BlancoFS wants to merge 9 commits intogiorgiopizz:masterfrom
Conversation
The last file in the list was always rejected
BlancoFS
changed the title
BlancoFS
changed the title
For some reason, an error occurs when you try to copy TTrees using the iterate function right after copying a single Branch "by hand" (i.e. the "tag" TTree). It's solved by making "tag" to be copied in the old ROOT.TFile way.
The alternative Snapshot function to copy the input TTrees was not completely correct as it returned a Streamer error when reading output files. The original development is fixed with "CloneTree()" function
giorgiopizz
added a commit
that referenced
this pull request
Mar 13, 2024
* merged .gitlab-ci.yml * Merged Dockerfile * merged check_condor/check_condor_status.py * merged samples.py * merged install.sh * merged fix_xrdfs.sh * merged setup.cfg * First attempt to merge BatchSubmission.py from ci_kaniko_matteo_polished * Updated BatchSubmission.py and mkShapesRDF.py to adress changes implemented previously by Mattia * Fixed an indentation error inside BatchSubmission.py * Fixed a typo in BatchSubmission.py * Added a new print inside BatchSubmission.py * Added missing queue statement * Install script has been updated to reflect shift to lxplus9 * Added conditions on -spool input argument for condor * Fixed a typo inside BatchSubmission.py * added basic documentation for the jdl_dict.py configuration file * Added jdl_dict.py inside docs/shapes/python * Restructure, format and linting * Custom installations supported, new hadd for MT from a list of files * Fix installation * Fix jdl_dict.py example in docs * Fix install, Dockerfile and documentation --------- Co-authored-by: Matteo Bartolini <matteo.bartolini@cern.ch> Co-authored-by: Giorgio Pizzati <giorgio.pizzati@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the first implementation of the Trigger module for the RDF Latinos framework.
The code uses Correccionlib to load efficiencies and SF from different json files included in the PR. In addition, a conver_to_json.py script is provided to make json files from the traditional txt files.
For simplicity, only UL efficiency files are integrated in the new framework.
The module has been validated using a DYJetsToLL sample with 460000 events. The results of the validation are attached here.
TriggerModuleRDf.pdf
In addition, two minor fixes have been made within the post processor module. First, when looking for files in DAS the first file was always rejected. Second, the option limitFiles=-1 always cut the ultimate object in the list.
Snapshot
When you try to access information from a TTree like "Runs" (copied from the input files to the output one) there is a memory corruption error related to the way in which the TTrees are copied.
This is solved using CloneTree()