[SHAPE] 2D histogram support, new hadd, support nuisances of type weight_rms and weight_envelope#17
Open
giorgiopizz wants to merge 2 commits intomasterfrom
Open
[SHAPE] 2D histogram support, new hadd, support nuisances of type weight_rms and weight_envelope#17giorgiopizz wants to merge 2 commits intomasterfrom
giorgiopizz wants to merge 2 commits intomasterfrom
Conversation
#9) * added condor queue selection and normalErrs, fixed hadd multithreading * removed submodule dependency and implemented work-around to arg_max bash limit * hadd reads directly from .txt file * fixing bash limit for real this time * forgot to add queue option to submit command, otherwise it takes the default value
… for subsamples. New hadd
mlizzo
reviewed
Nov 23, 2023
| else: | ||
| variations = (float(values), 2.0 - float(values)) | ||
| if float(values) < 1e-8: | ||
| print("lnN cannot be zero! Check nuisance", nuisacen, file=sys.stderr) |
There was a problem hiding this comment.
I guess it's a typo: nuisacen -> nuisance
Owner
Author
There was a problem hiding this comment.
Thank for spotting that!
mlizzo
reviewed
Nov 24, 2023
| cling::DynamicLibraryManager::loadLibrary(): libGLU.so.1: cannot open shared object file: No such file or directory | ||
| Error in <TNetXNGFile::Close>: | ||
| Warning in <TChain::AddFile>: Adding tree with no entries from file | ||
| """ |
There was a problem hiding this comment.
maybe we can also add the warning below among strings that are classified as "normal errors"
Info in <ACLiC>: unmodified script has already been compiled and loaded
mlizzo
reviewed
Nov 24, 2023
| elif isinstance(h, ROOT.TH1I): | ||
| dtype = np.int | ||
| else: | ||
| print("Histogram of type", h, "is not supperted", file=sys.stderr) |
There was a problem hiding this comment.
supperted -> supported (ignore this if you don't have time to update it and sorry if I am too nitpicking)
mlizzo
reviewed
Nov 24, 2023
| + _h.GetBinContent(lastBin + 1), | ||
|
|
||
| _h2 = ROOT.TH1D( | ||
| new_name, _h.GetName(), nx * ny, 1, nx * ny |
There was a problem hiding this comment.
shouldn't the unrolled TH1D histogram have nx * ny bins from 1 to nx * ny + 1 ? I think there's one bin less because of the missing + 1 in the last argument, but please correct me if I misunderstood
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
runner.py. Correct handling of folding (for both bin content and sumw2)weight_rmandweight_envelope. Taking the QCDscale as an example forweight_envelopevaried histograms will be created for eachLHEScaleWeightspecified (so 6 histograms).mkShapesRDF -o 2willhaddsingle histograms and the envelope will be computed right after that, storing only the final envelope up and downhadd2is included with this PR to support multithreaded hadd when using indirect files.hadd2 -j 10 @fileList.txtwill correctly work now.hadd2is compiled withinstall.sh. The path containing its binary will be added to the $PATH, namelyutils/bin.fnmatchedto subsamples keys (e.g.DY*will matchDY,DY_hardJetsandDY_PUJets)