Skip to content

component-updates: check pacman-repo, not the Azure Blob storage#218

Merged
dscho merged 1 commit into
git-for-windows:mainfrom
dscho:check-pacman-repo
Jun 11, 2026
Merged

component-updates: check pacman-repo, not the Azure Blob storage#218
dscho merged 1 commit into
git-for-windows:mainfrom
dscho:check-pacman-repo

Conversation

@dscho

@dscho dscho commented Jun 10, 2026

Copy link
Copy Markdown
Member

Until recently, Git for Windows uploaded Pacman packages to wingit.blob.core.windows.net, and the /add relnote flow verified the deployment by HEAD-probing each expected .pkg.tar.xz URL there. Now that the Azure Blob deployment is gone (see build-extra@5b44c34 and the surrounding work), every probe returns 404 and /add relnote always claims the deployment is missing. The first concrete fallout was git-for-windows/git#6272 (comment) where OpenSSL 3.5.7-1 was reported as undeployed despite the packages having landed at the tip of each arch branch in git-for-windows/pacman-repo.

This PR points the existing HEAD probe at the new home: https://raw.githubusercontent.com/git-for-windows/pacman-repo/refs/heads/<arch>/<filename>. That URL serves the file at the branch tip, so blobs pruned from a tip will correctly report as missing (matching pacman -Syu semantics). The previous arch.replace(/_/g, '-') mapping x86_64 to x86-64 was a legacy Azure-container naming quirk and is dropped, since pacman-repo's branch is just x86_64.

Verified end-to-end against the live git-for-windows/pacman-repo tree:

openssl-3.5.7-1-x86_64.pkg.tar.xz => false (present)
openssl-9.9.9-1-x86_64.pkg.tar.xz => true  (missing)
mingw-w64-clang-aarch64-openssl-3.5.7-1-any.pkg.tar.xz => false (present)

All 25 existing tests pass; only the URL constants in the tests needed updating to match the new host.

Until recently, Git for Windows uploaded Pacman packages to an
Azure Blob Storage container at `wingit.blob.core.windows.net`,
and `getMissingDeployments()` verified a package was published by
issuing a HEAD request for each expected `.pkg.tar.xz` URL there.

Now that we no longer deploy to that container (see
git-for-windows/build-extra@5b44c34
and the surrounding work), the Azure Blob URLs return 404 for
every newly built package, and `/add relnote` always claims the
deployment is missing. The first concrete fallout was on
git-for-windows/git#6272 (comment)
where the OpenSSL 3.5.7-1 release was reported as undeployed even
though the packages had landed at the tip of each arch branch in
https://github.com/git-for-windows/pacman-repo.

Point the existing HEAD-based probe at the new home. The package
files now live at
`https://raw.githubusercontent.com/git-for-windows/pacman-repo/refs/heads/<arch>/<filename>`,
which serves the file at the branch tip (so blobs that get pruned
from a branch's tip will correctly report as missing, matching
`pacman -Syu` semantics). The previous `arch.replace(/_/g, '-')`
mapped `x86_64` to `x86-64` to match the legacy Azure container
naming; pacman-repo's branch is just `x86_64`, so drop the
replacement.

Assisted-by: Opus 4.7
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho marked this pull request as ready for review June 10, 2026 18:35
@dscho dscho merged commit 39de100 into git-for-windows:main Jun 11, 2026
1 check passed
@dscho dscho deleted the check-pacman-repo branch June 11, 2026 06:10
dscho added a commit to git-for-windows/git-for-windows-automation that referenced this pull request Jun 11, 2026
A leftover comment in `update-scripts/ensure-not-yet-deployed.sh` still
claims that "the Pacman repository is hosted in an Azure Blobs container
where directory names cannot contain underscores, hence we needed to
replace that character with a dash." That note has been actively
contradicted by the surrounding code ever since
[7766f3c](7766f3c)
migrated the URL to
`https://github.com/git-for-windows/pacman-repo/blob/$subdir/$file` and
changed the rewrite from `any|x86_64) subdir=x86-64;;` to `any)
subdir=x86_64;;` in the same commit, but forgot to delete this note.

Followup to the parallel fix in
[gfw-helper-github-app#218](git-for-windows/gfw-helper-github-app#218),
which addresses [git-for-windows/git#6272
(comment)](git-for-windows/git#6272 (comment)).
The presence check here was already pointing at pacman-repo and works
correctly; only the stale documentation needs to go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant