Add Options.FSRoot to bound pom.xml parent resolution#37
Draft
andrew wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on git-pkgs/pom#10.
pomXMLParseris the only parser that touches the filesystem: it follows<parent><relativePath>viapom.LocalFetcherso multi-module projects resolve${project.version}and parent-defined properties. Server-side that means a pushedpom.xmlcan read arbitrary files relative to the process working directory.This adds
manifests.Options{FSRoot string}and threads it through a newcore.FSRootParserinterface that onlypomXMLParserimplements. WithFSRootempty (the default, and what existingParse(filename, content)calls get), parsing is a pure function ofcontentand the parent walk is skipped. WithFSRootset, parent lookup is jailed to that directory by the upstreampom.NewLocalFetcherFromchange.Parsekeeps its existing signature via a variadicopts ...Optionsso current callers compile unchanged; they lose multi-module parent resolution until they passOptions{FSRoot: repoRoot}.go.modcurrently carries areplace github.com/git-pkgs/pom => ../pomdirective so this builds against the unreleased API. That will be swapped for a tagged version once pom#10 is released, before this comes out of draft.