fix: use nextTick instead of tickAfterNext for highlight rendering#32
Open
lgallard wants to merge 1 commit into
Open
fix: use nextTick instead of tickAfterNext for highlight rendering#32lgallard wants to merge 1 commit into
lgallard wants to merge 1 commit into
Conversation
tickAfterNext defers the document reload by two UI cycles, creating a window where KOReader caches stale display state without the synced highlights. This required a font resize to force a full re-render. nextTick schedules the reload on the very next cycle, preventing the stale cache issue.
lgallard
force-pushed
the
fix/rendering-and-critical-bugs
branch
from
d65a2ef to
a336f1a
Compare
lgallard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I was having an issue where highlights wouldn't render after sync — had to resize fonts every time to force a re-render.
I used AI to help me dig into the root cause:
tickAfterNext()defers the document reload by two UI cycles, creating a window where KOReader caches stale display state without the new highlights. Switching tonextTick()schedules the reload on the very next cycle, preventing the stale cache.Test plan