A proof-of-concept for a long-running function#12722
Closed
Byron wants to merge 2 commits intogitbutlerapp:masterfrom
Closed
A proof-of-concept for a long-running function#12722Byron wants to merge 2 commits intogitbutlerapp:masterfrom
Byron wants to merge 2 commits intogitbutlerapp:masterfrom
Conversation
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
While it's using `gix::Progress`, it could also use anything else for that. There might also be alternatives that offer checks for cancellation as part of the progress, but I found it better to make this explcit. Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
That's particularly interesting for the Progress visualisation and instantiation, as our 'renderer' would be a forwarder of sorts to pass the progress state on to the frontend. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Contributor
|
@Byron I hope it's fine that I pushed a commit to this PR. Can't build a stack from a fork branch (I think). Basically, I added a two Napi functions:
I added a POC of how that works in the test.ts in the but-sdk side of things and it seems to work nicely |
Contributor
|
ohhhh I can't push |
Contributor
|
I created this PR: #12802 |
Collaborator
Author
|
Sorry for the hassle, I should have remembered to push into this repository. 
In any case, closing this as superseded by #12802 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
but-litewe need a way to deal with (potentially) long-running operations.The PoC presented here is pretty much based on what
gixdoes when it comes to progress and cancellation.Tasks
but-testingintegration to see the Rust sideNotes for the Reviewer
You can work backwards from
cargo run -p but-testing -- long-running -d 5s, which represents a Rust caller.estib Tasks