Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the web “Nightly Builds” page to avoid showing the featured/latest nightly release again in the “Other nightly builds” list, reducing user confusion when downloading older versions.
Changes:
- Compute
otherNightliesin the route loader by excluding the latest nightly release. - Update the nightly page Svelte component to consume/render
otherNightliesinstead of the full nightly list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/web/src/routes/nightly/+page.ts | Adds otherNightlies derived from fetched nightlies and returns it from load(). |
| apps/web/src/routes/nightly/+page.svelte | Switches “Other nightly builds” section to use otherNightlies from data. |
You can also share your feedback on Copilot code review. Take the survey.
| const otherNightlies = latestNightly | ||
| ? nightlies.filter((release) => release.version !== latestNightly.version) | ||
| : nightlies; |
|
@Byron what's the difference between |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5902d1c8b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const otherNightlies = latestNightly | ||
| ? nightlies.filter((release) => release.version !== latestNightly.version) |
There was a problem hiding this comment.
Filtering the newest nightly out here removes the only place that renders ReleaseDownloadLinks for that release. On apps/web/src/routes/nightly/+page.svelte, the hero only exposes macOS, Linux .deb/.rpm/CLI, and Windows MSI links, while ReleaseDownloadLinks is what surfaces AppImage, Windows EXE, and any other extra artifacts. When the latest nightly includes one of those builds, users can no longer download it from /nightly, which is a regression from the previous behavior.
Useful? React with 👍 / 👎.
Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
|
OtherNightlies is nightlies, without the current version. It's basically |
This seems more natural to me, particularly because I fell for it multiple times now that I tried to download the previous version, but got the current one.