Merged
Conversation
Add 6 tests covering previously uncovered paths in env.py: - get_int_env_var returning None for non-integer values - get_env_vars loading .env file when test=False - REPOSITORY validation for values starting with / - TITLE exceeding 70 character limit - BODY exceeding 65536 character limit - COMMIT_MESSAGE exceeding 65536 character limit Coverage: 96% → 100% (204 statements, 0 missed) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Zack Koppert <zkoppert@github.com>
The test was covering lines 90-91 for coverage metrics but not asserting that load_dotenv() was actually invoked. Mock load_dotenv and verify it is called once when test=False. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Zack Koppert <zkoppert@github.com>
Collaborator
Author
|
should we pin coverage requirements to 100%? |
Collaborator
Let's live dangerously. Why not? |
Bump --cov-fail-under from 80 to 100 now that all code paths are covered, per review feedback on PR #383. Signed-off-by: Zack Koppert <zkoppert@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Zack Koppert <zkoppert@github.com>
jmeridth
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
Adds 6 tests to cover all previously uncovered paths in
env.py, bringing the repo from 96% to 100% test coverage.The uncovered lines were all validation/error paths that had no test exercising them:
get_int_env_varreturningNonefor non-integer valuestest_get_int_env_var_returns_none_for_non_integerget_env_varsloading.envfile whentest=Falsetest_get_env_vars_loads_dotenv_when_not_testREPOSITORYstarting with/validationtest_get_env_vars_raises_for_repository_starting_with_slashTITLEexceeding 70 char limittest_get_env_vars_raises_for_title_too_longBODYexceeding 65536 char limittest_get_env_vars_raises_for_body_too_longCOMMIT_MESSAGEexceeding 65536 char limittest_get_env_vars_raises_for_commit_message_too_longTesting
make lintclean (pylint 10/10, mypy, flake8, isort, black)Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing