Add GitHub footer and cookie management to home page#2327
Open
brunoborges wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3adc4d03-d0c9-40f9-abbe-937931f6c523
github-actions
Bot
added
new-submission
Contributor
|
🔴 Contributor Reputation Check: HIGH risk
Maintainers: please review this contributor before merging. |
github-actions
Bot
added
the
needs-review:HIGH
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a home-page-only GitHub footer with legal links, social channels, and cookie-consent management.
Changes:
- Adds responsive legal and social footer UI.
- Loads GitHub consent runtime assets on the home page.
- Adds the consent dialog host element and cookie-management action.
Show a summary per file
| File | Description |
|---|---|
website/src/components/Head.astro |
Loads consent bootstrap script on the home page. |
website/src/components/Footer.astro |
Adds footer UI, consent elements, and styling. |
website/public/github-cookie-consent.js |
Loads GitHub consent runtime dependencies. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Medium
Comment on lines
+25
to
+27
| async function loadAssets() { | ||
| for (const asset of assets) { | ||
| await new Promise((resolve, reject) => { |
| <nav aria-label="Legal and resource links" class="subfooter-legal-nav"> | ||
| <ul class="subfooter-legal"> | ||
| <li class="subfooter-copyright"> | ||
| <time datetime={String(currentYear)}>© {currentYear} GitHub, Inc.</time> |
aaronpowell
added a commit
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
The home page was missing the standard GitHub legal and social footer, including a way for visitors to manage cookie preferences.
This adds the footer used by
github/dev-daysto the generated home page, with legal links, GitHub social channels, responsive styling, and GitHub's shared OneTrust cookie-management dialog. The footer and consent runtime are limited to the home page, and the locale picker is intentionally omitted because this site is not internationalized.The consent loader appends GitHub's runtime assets after Astro's page scripts so lazy-loaded consent chunks continue resolving from
github.githubassets.cominstead of the local site origin.Type of Contribution
Additional Notes
The Astro production build succeeds. The footer was checked at desktop and mobile widths, and the Manage cookies button opens the shared GitHub consent dialog.
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.