Skip to content

Commit 320a00b

Browse files
committed
Delete simple API::Nodes
1 parent 5b66a15 commit 320a00b

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

  • python/ql/src/experimental/semmle/python/frameworks

python/ql/src/experimental/semmle/python/frameworks/XML.qll

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,10 @@ private import experimental.semmle.python.Concepts
99
private import semmle.python.ApiGraphs
1010

1111
private module XML {
12-
/** Gets a reference to the `xml` module. */
13-
private API::Node xml() { result = API::moduleImport("xml") }
14-
1512
/** Gets a reference to `xml.etree.ElementTree`. */
16-
private API::Node xmlEtree() { result = xml().getMember("etree").getMember("ElementTree") }
13+
private API::Node xmlEtree() {
14+
result = API::moduleImport("xml").getMember("etree").getMember("ElementTree")
15+
}
1716

1817
/** Gets a call to `xml.etree.ElementTree.XMLParser`. */
1918
private class XMLEtreeParser extends DataFlow::CallCfgNode, XMLParser::Range {
@@ -53,7 +52,7 @@ private module XML {
5352
}
5453

5554
/** Gets a reference to `xml.sax`. */
56-
private API::Node xmlSax() { result = xml().getMember("sax") }
55+
private API::Node xmlSax() { result = API::moduleImport("xml").getMember("sax") }
5756

5857
/**
5958
* Gets a call to `xml.sax.make_parser` and following calls.
@@ -93,11 +92,8 @@ private module XML {
9392
}
9493
}
9594

96-
/** Gets a reference to `lxml`. */
97-
private API::Node lxml() { result = API::moduleImport("lxml") }
98-
9995
/** Gets a reference to `lxml.etree`. */
100-
private API::Node lxmlEtree() { result = lxml().getMember("etree") }
96+
private API::Node lxmlEtree() { result = API::moduleImport("lxml").getMember("etree") }
10197

10298
/**
10399
* Gets a call to `lxml.etree.XMLParser` or `lxml.etree.get_default_parser` and `mayBeDangerous()`
@@ -166,7 +162,9 @@ private module XML {
166162
}
167163

168164
/** Gets a reference to `xml.dom.minidom` or `xml.dom.pulldom`. */
169-
private API::Node xmlDom() { result = xml().getMember("dom").getMember(["mini", "pull"] + "dom") }
165+
private API::Node xmlDom() {
166+
result = API::moduleImport("xml").getMember("dom").getMember(["mini", "pull"] + "dom")
167+
}
170168

171169
/**
172170
* Gets a call to `xml.dom.minidom.parse` or `xml.dom.pulldom.parse`.

0 commit comments

Comments
 (0)