-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update MaD for System.Web.HttpUtility #21299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update MaD for System.Web.HttpUtility #21299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the C# Models-as-Data (MaD) for System.Web.HttpUtility so that UrlDecode is treated as a taint-propagating method, improving dataflow tracking for SSRF and URL path traversal scenarios.
Changes:
- Add taint-propagation summaries for
System.Web.HttpUtility.UrlDecodeoverloads in the MaD YAML model. - Update library-test expected summary outputs to include the new
UrlDecodeentries. - Add a change note describing the modeling update.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| csharp/ql/lib/ext/System.Web.model.yml | Adds summary model entries marking HttpUtility.UrlDecode overloads as taint-propagating. |
| csharp/ql/test/library-tests/dataflow/library/FlowSummaries.expected | Updates expected library summary output to include UrlDecode taint flow. |
| csharp/ql/test/library-tests/dataflow/library/FlowSummariesFiltered.expected | Updates filtered expected summary output similarly. |
| csharp/ql/lib/change-notes/2026-02-09-update-system.web.httputility-model.md | Adds a change note for the modeling update (currently contains a namespace/type mistake). |
csharp/ql/lib/change-notes/2026-02-09-update-system.web.httputility-model.md
Outdated
Show resolved
Hide resolved
Click to show differences in coveragecsharpGenerated file changes for csharp
- System,"``System.*``, ``System``",47,12491,59,5
+ System,"``System.*``, ``System``",47,12495,59,5
- Totals,,107,14904,415,9
+ Totals,,107,14908,415,9
- System,59,47,12491,,6,5,12,,,4,1,,31,2,,6,15,17,4,3,,6378,6113
+ System,59,47,12495,,6,5,12,,,4,1,,31,2,,6,15,17,4,3,,6382,6113 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
michaelnebel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Lets run DCA before merging (I will start a DCA run now).
Update MaD for C# related to SSRF and URL path traversal scenarios.
System.Web.HttpUtility UrlDecode Method
Update model to treat
UrlDecodeas a taint method.UrlEncodeis already treated as a taint method.Example: