chore: optimize devcontainer for Codespaces prebuilds#56
Merged
Conversation
- Move install commands from postCreateCommand to onCreateCommand so they are cached during prebuild, reducing codespace startup time. - Remove gh extension install for gh-copilot since gh copilot is now a built-in command in GitHub CLI v2.88.0+. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes the devcontainer setup for Codespaces by simplifying the container creation install steps and removing the now-unneeded GitHub CLI Copilot extension install.
Changes:
- Removes
gh extension install github/gh-copilotfromonCreateCommand. - Keeps Python (
pytest) and Node (@github/copilot) installs inonCreateCommand.
Show a summary per file
| File | Description |
|---|---|
| .devcontainer/devcontainer.json | Removes gh-copilot extension installation from the devcontainer creation command. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| } | ||
| }, | ||
| "onCreateCommand": "pip install pytest && npm install -g @github/copilot && gh extension install github/gh-copilot", | ||
| "onCreateCommand": "pip install pytest && npm install -g @github/copilot", |
There was a problem hiding this comment.
The PR description says install commands were moved from postCreateCommand to onCreateCommand, but this diff only removes the gh extension install github/gh-copilot portion; there is no postCreateCommand change in this PR. Please update the PR description (or adjust the devcontainer config) so the stated motivation about prebuild caching matches the actual change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
postCreateCommandtoonCreateCommandso they are cached during Codespaces prebuilds, reducing startup time.gh extension install github/gh-copilotsincegh copilotis now a built-in command in GitHub CLI v2.88.0+ (docs).