-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add explicit session reset APIs #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
redsun82
wants to merge
3
commits into
github:main
Choose a base branch
from
redsun82:reset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@redsun82 Can you clarify if there's some part of the logic here that needs to be done inside the SDK as opposed to being done by client apps?
I would have thought client apps are already able to destroy a session and then create a new one with equivalent config. What extra thing do we get from having
ResetSessionAsyncas an SDK feature?I'm asking because this is quite an opinionated flow - it's not at all obvious that "reset" should actually mean "destroy and get a different instance". From the name alone I think people would expect "reset" to mutate the session in some way that resets it (so you end up with the same session object, same session ID), not to create a whole new session with a new ID.
So I'm wondering if we could avoid this risk of confusion by keeping this logic inside the apps that need it, rather than making it a general SDK feature.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @SteveSandersonMS thanks for the feedback, this is a point I also hesitated a lot on.
My thinking here is that apps can technically do destroy + create, but it turns out there is a bunch of SDK-owned state around that sequence: pending request queues, per-session handlers/delegates, active-session maps, stale handles, and concurrent reset guards, and apps can get that subtly wrong.
As for whether it should be an in-place method: that would have been my go-to as well, it's just that it's not the current behaviour of the CLI's
/clear. But maybe we should turn this around, make the most natural addition to the SDK and just slightly change/clear's semantics to go with that?I remain very open to suggestions! For context, my main objective is to add
/clearto the Copilot desktop app, so the more I'm able to share through the SDK the happier I am, but we also don't want to muddy the SDK just for that.