Remove no-explicit-any violations from search files (#61663)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: heiskr

eslint.config.ts

@@ -239,13 +239,6 @@ export default [
       'src/frame/components/context/MainContext.tsx',
       'src/landings/components/CookBookFilter.tsx',
       'src/languages/lib/correct-translation-content.ts',
-      'src/search/components/hooks/useAISearchAutocomplete.ts',
-      'src/search/components/hooks/useAISearchLocalStorageCache.ts',
-      'src/search/components/input/SearchOverlay.tsx',
-      'src/search/lib/get-elasticsearch-results/ai-search-autocomplete.ts',
-      'src/search/lib/get-elasticsearch-results/general-search.ts',
-      'src/search/scripts/index/index-cli.ts',
-      'src/search/scripts/index/utils/indexing-elasticsearch-utils.ts',
     ],
     rules: {
       '@typescript-eslint/no-explicit-any': 'off',

src/search/components/hooks/useAISearchAutocomplete.ts

@@ -125,8 +125,15 @@ export function useCombinedSearchResults({
         // Update state with fetched results
         setSearchOptions(results)
         setSearchLoading(false)
-      } catch (error: any) {
-        if (error.name === 'AbortError') {
+      } catch (error: unknown) {
+        // Aborted fetch() requests reject with a DOMException (not always an
+        // Error instance), so match on the name rather than the prototype.
+        if (
+          typeof error === 'object' &&
+          error !== null &&
+          'name' in error &&
+          (error as { name?: unknown }).name === 'AbortError'
+        ) {
           return
         }
         console.error(error)

src/search/components/hooks/useAISearchLocalStorageCache.ts

@@ -16,7 +16,7 @@ interface CacheIndexEntry {
  *
  * Cached items are cached under a prefix, for a fixed number of days
  */
-export function useAISearchLocalStorageCache<T = any>(
+export function useAISearchLocalStorageCache<T = unknown>(
   cacheKeyPrefix: string = 'ai-query-cache',
   maxEntries: number = 1000,
   expirationDays: number = 30,

src/search/components/input/SearchOverlay.tsx

@@ -190,7 +190,7 @@ export function SearchOverlay({
       generalWithView.push({
         title: t('search.overlay.view_all_search_results'),
         isViewAllResults: true,
-      } as any)
+      } as unknown as GeneralSearchHitWithOptions)
     } else if (autoCompleteSearchError) {
       if (urlSearchInputQuery.trim() !== '') {
         generalWithView.push({
@@ -203,7 +203,7 @@ export function SearchOverlay({
       generalWithView.push({
         title: t('search.overlay.no_results_found'),
         isNoResultsFound: true,
-      } as any)
+      } as unknown as GeneralSearchHitWithOptions)
     } else {
       generalWithView = []
     }
@@ -423,7 +423,7 @@ export function SearchOverlay({
         // If it's the "no results found" option, skip it
         if (
           newIndex >= selectedIndex &&
-          (combinedOptions[newIndex]?.option as any)?.isNoResultsFound
+          (combinedOptions[newIndex]?.option as GeneralSearchHitWithOptions)?.isNoResultsFound
         ) {
           newIndex += 1
         }
@@ -454,7 +454,7 @@ export function SearchOverlay({
         // If it's the "no results found" option, skip it
         if (
           newIndex <= selectedIndex &&
-          (combinedOptions[newIndex]?.option as any)?.isNoResultsFound
+          (combinedOptions[newIndex]?.option as GeneralSearchHitWithOptions)?.isNoResultsFound
         ) {
           newIndex -= 1
         }

src/search/lib/get-elasticsearch-results/ai-search-autocomplete.ts

@@ -19,7 +19,7 @@ export async function getAISearchAutocompleteResults({
   const t0 = new Date()
   const client = getElasticsearchClient() as Client
 
-  const searchQuery: any = {
+  const searchQuery: estypes.SearchRequest = {
     index: indexName,
     size,
     // Send absolutely minimal from Elasticsearch to here. Less data => faster.

src/search/lib/get-elasticsearch-results/general-search.ts

@@ -67,22 +67,24 @@ export async function getGeneralSearchResults(
     },
   })
 
-  const matchQuery: Record<string, any> = {
-    bool: {
-      should: matchQueries,
-      // This allows filtering by toplevel later.
-      minimum_should_match: 1,
-    },
+  const matchBool: estypes.QueryDslBoolQuery = {
+    should: matchQueries,
+    // This allows filtering by toplevel later.
+    minimum_should_match: 1,
+  }
+  const matchQuery: estypes.QueryDslQueryContainer = {
+    bool: matchBool,
   }
 
   const toplevelArray = toplevel || []
   if (toplevelArray.length) {
-    matchQuery.bool.filter = matchQuery.bool.filter || []
-    matchQuery.bool.filter.push({
+    const filters = Array.isArray(matchBool.filter) ? matchBool.filter : []
+    filters.push({
       terms: {
         toplevel: toplevelArray,
       },
     })
+    matchBool.filter = filters
   }
 
   const highlightFields = Array.from(highlights || DEFAULT_HIGHLIGHT_FIELDS)
@@ -152,7 +154,7 @@ export async function getGeneralSearchResults(
     throw new Error(`Unrecognized sort enum '${sort}'`)
   }
 
-  const result = await client.search(searchQuery)
+  const result = await client.search<GeneralSearchSource>(searchQuery)
 
   const hitsAll = result.hits
   const hits = getHits(hitsAll.hits, {
@@ -177,10 +179,12 @@ export async function getGeneralSearchResults(
   return { meta, hits, aggregations: aggregationsResult }
 }
 
-function getAggregations(aggregate?: string[]): Record<string, any> | undefined {
+function getAggregations(
+  aggregate?: string[],
+): Record<string, estypes.AggregationsAggregationContainer> | undefined {
   if (!aggregate || !aggregate.length) return undefined
 
-  const aggs: Record<string, any> = {}
+  const aggs: Record<string, estypes.AggregationsAggregationContainer> = {}
   for (const key of aggregate) {
     aggs[key] = {
       terms: {
@@ -194,18 +198,19 @@ function getAggregations(aggregate?: string[]): Record<string, any> | undefined
 
 function getAggregationsResult(
   aggregate?: string[],
-  result?: Record<string, any>,
+  result?: Record<string, estypes.AggregationsAggregate>,
 ): Record<string, SearchAggregation[]> | undefined {
   if (!aggregate || !aggregate.length || !result) return undefined
   const aggregations: Record<string, SearchAggregation[]> = {}
   for (const key of aggregate) {
-    if (result[key]?.buckets) {
-      aggregations[key] = result[key].buckets
-        .map((bucket: any) => ({
+    const agg = result[key] as { buckets?: Array<{ key: string; doc_count: number }> } | undefined
+    if (agg?.buckets) {
+      aggregations[key] = agg.buckets
+        .map((bucket) => ({
           key: bucket.key as string,
           count: bucket.doc_count as number,
         }))
-        .sort((a: { key: string }, b: { key: string }) => a.key.localeCompare(b.key))
+        .sort((a, b) => a.key.localeCompare(b.key))
     }
   }
   return aggregations
@@ -417,8 +422,16 @@ interface GetHitsOptions {
   include: AdditionalIncludes[]
 }
 
+interface GeneralSearchSource {
+  url: string
+  title: string
+  breadcrumbs: string
+  popularity?: number
+  [key: string]: unknown
+}
+
 function getHits(
-  hits: estypes.SearchHit<any>[],
+  hits: estypes.SearchHit<GeneralSearchSource>[],
   { indexName, debug = false, highlightFields, include }: GetHitsOptions,
 ): GeneralSearchHit[] {
   return hits.map((hit) => {
@@ -435,22 +448,23 @@ function getHits(
       hitHighlights[key] = (hit.highlight && hit.highlight[key]) || []
     }
 
+    const source = hit._source!
     const result: GeneralSearchHit = {
       id: hit._id!,
-      url: hit._source.url,
-      title: hit._source.title,
-      breadcrumbs: hit._source.breadcrumbs,
+      url: source.url,
+      title: source.title,
+      breadcrumbs: source.breadcrumbs,
       highlights: hitHighlights,
     }
     if (debug) {
       result.score = hit._score ?? 0.0
-      result.popularity = hit._source.popularity ?? 0.0
+      result.popularity = source.popularity ?? 0.0
       if (isDevMode) {
         result.es_url = `http://localhost:9200/${indexName}/_doc/${hit._id}`
       }
     }
     for (const field of include) {
-      result[field] = hit._source[field]
+      result[field] = source[field] as string
     }
     return result
   })

src/search/scripts/index/index-cli.ts

@@ -73,13 +73,18 @@ const generalSearchCommand = new Command('general-search')
   .action(async (sourceDirectory, options) => {
     try {
       await indexGeneralSearch(sourceDirectory, options)
-    } catch (error: any) {
-      if (error instanceof errors.ElasticsearchClientError) {
-        if ((error as any)?.meta) {
-          console.error('Error meta: %O', (error as any).meta)
-        }
+    } catch (error: unknown) {
+      if (
+        error instanceof errors.ElasticsearchClientError &&
+        'meta' in error &&
+        (error as { meta?: unknown }).meta
+      ) {
+        console.error('Error meta: %O', (error as { meta?: unknown }).meta)
       }
-      console.error('general-search indexing error:', error.message)
+      console.error(
+        'general-search indexing error:',
+        error instanceof Error ? error.message : error,
+      )
       process.exit(1)
     }
   })
@@ -123,13 +128,18 @@ const aiSearchAutocompleteCommand = new Command('ai-search-autocomplete')
         versions,
         indexPrefix,
       })
-    } catch (error: any) {
-      if (error instanceof errors.ElasticsearchClientError) {
-        if ((error as any)?.meta) {
-          console.error('Error meta: %O', (error as any).meta)
-        }
+    } catch (error: unknown) {
+      if (
+        error instanceof errors.ElasticsearchClientError &&
+        'meta' in error &&
+        (error as { meta?: unknown }).meta
+      ) {
+        console.error('Error meta: %O', (error as { meta?: unknown }).meta)
       }
-      console.error('ai-search-autocomplete indexing error:', error.message)
+      console.error(
+        'ai-search-autocomplete indexing error:',
+        error instanceof Error ? error.message : error,
+      )
       process.exit(1)
     }
   })

src/search/scripts/index/utils/indexing-elasticsearch-utils.ts

@@ -36,7 +36,7 @@ export async function populateIndex(
   client: Client,
   indexAlias: string,
   indexName: string,
-  records: any[],
+  records: Record<string, unknown>[],
   options: Options,
 ) {
   console.log(chalk.yellow(`\nIndexing ${chalk.bold(indexName)}`))