Skip to content

[WIP] task: validate built-in hmac and fix tests#32

Closed
Copilot wants to merge 4 commits into
mainfrom
copilot/fix-31
Closed

[WIP] task: validate built-in hmac and fix tests#32
Copilot wants to merge 4 commits into
mainfrom
copilot/fix-31

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 12, 2025

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original issue description:

The lib/hooks/plugins/auth/hmac.rb file has gotten quite large and unwieldy. Please check it out and ensure it follows ruby best practices, is clean and concise, and fix the failing script/test tests related to it. Do not make any logic breaking changes.

A lot of the logic related to timestamps has gotten quite messy. It passes integration and acceptance tests, but the actual unit test script/test are messy. Please refactor and make this better.

Fixes #31.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: GrantBirki <23362539+GrantBirki@users.noreply.github.com>
@GrantBirki
Copy link
Copy Markdown
Contributor

@copilot try again

@GrantBirki
Copy link
Copy Markdown
Contributor

@copilot try again

@GrantBirki
Copy link
Copy Markdown
Contributor

@copilot try again

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jun 12, 2025

@copilot try again

I'll restart the approach to fix the failing HMAC tests. Looking at the test failures, there are specific issues with timestamp parsing, validation logic, and regex patterns that need to be addressed.

Copilot AI and others added 2 commits June 12, 2025 20:42
…x patterns

Co-authored-by: GrantBirki <23362539+GrantBirki@users.noreply.github.com>
Co-authored-by: GrantBirki <23362539+GrantBirki@users.noreply.github.com>
@GrantBirki GrantBirki closed this Jun 12, 2025
@GrantBirki GrantBirki deleted the copilot/fix-31 branch June 12, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task: validate built-in hmac and fix tests

2 participants