Enhance HMAC timestamp validation: improve parsing logic and add test…#33
Merged
Conversation
…s for ISO 8601 UTC format
…d Unix timestamp methods
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances timestamp validation for HMAC authentication by unifying parsing to epoch seconds, tightening input checks, and adding an acceptance test for Ruby’s default ISO 8601 format.
- Added an acceptance test covering
Time.now.utc.iso8601timestamps - Refactored
parse_timestampto reject control chars/whitespace and return integer seconds - Updated ISO 8601 regex and parsing to use
Time.parse, with warning logs for invalid inputs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| spec/acceptance/acceptance_tests.rb | Added acceptance test for ISO 8601 timestamps using Ruby’s iso8601 method |
| lib/hooks/plugins/auth/hmac.rb | Refactored timestamp parsing: control-character checks, unified return type, regex adjustment |
Comments suppressed due to low confidence (1)
spec/unit/hooks/plugins/auth/hmac_spec.rb:1
- There are no unit tests covering parse_timestamp, parse_iso8601_timestamp, and parse_unix_timestamp edge cases (e.g., invalid formats, control characters, whitespace); consider adding tests to verify each path.
// new tests for parse_timestamp
…e check (redundant)
…stamp and clarify redundancy in checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s for ISO 8601 UTC format