General improvements#60
Merged
Merged
Conversation
…nherit from ancestors when loading custom plugins
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR strengthens plugin loading by adding missing-class error tests, refines constant lookups in the loader, and cleans up the shared-secret validation variable.
- Added specs to verify errors when a custom plugin class is not defined for auth, handler, lifecycle, and instrument plugins
- Switched to safe
const_getcalls with clear error messages inplugin_loader.rb - Renamed
raw_secrettoprovided_secretin the shared-secret validator for clarity
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| spec/unit/lib/hooks/core/plugin_loader_spec.rb | Added tests for missing-class errors across all plugin types |
| lib/hooks/plugins/auth/shared_secret.rb | Renamed raw_secret to provided_secret and updated comparisons |
| lib/hooks/core/plugin_loader.rb | Replaced global lookups with safe const_get and custom errors |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.