Config Updates#63
Merged
Merged
Conversation
…related tests. All refs to the handler dir must be made through `handler_plugin_dir` going forward to be consistent
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the legacy handler_dir configuration to handler_plugin_dir across tests, schema, loader, and documentation.
- Updated specs to use
handler_plugin_dir - Removed
handler_dirfrom the Dry schema and environment mappings - Revised docs to reflect
handler_plugin_dir
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/unit/lib/hooks/core/config_validator_spec.rb | Updated tests to replace handler_dir with handler_plugin_dir |
| lib/hooks/core/config_validator.rb | Removed handler_dir from the global config schema |
| lib/hooks/core/config_loader.rb | Dropped legacy HOOKS_HANDLER_DIR environment mapping |
| docs/design.md | Updated configuration references to handler_plugin_dir |
Comments suppressed due to low confidence (3)
lib/hooks/core/config_loader.rb:129
- Removing the legacy HOOKS_HANDLER_DIR mapping breaks backward compatibility; consider mapping it to handler_plugin_dir with a deprecation warning.
env_mappings = {
docs/design.md:350
- [nitpick] The term
plugin_diris not defined in the schema—clarify whether this refers toauth_plugin_dir,lifecycle_plugin_dir, or both.
* Plugin classes are loaded from `plugin_dir` and registered based on class inheritance
lib/hooks/core/config_loader.rb:130
- Add a unit test to verify that HOOKS_HANDLER_PLUGIN_DIR is correctly loaded into handler_plugin_dir in the environment config loader.
"HOOKS_HANDLER_PLUGIN_DIR" => :handler_plugin_dir,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.