Skip to content

Replace local file ref with workspace#17

Merged
jasonrclark merged 1 commit intomainfrom
add-npm-workspace
May 6, 2025
Merged

Replace local file ref with workspace#17
jasonrclark merged 1 commit intomainfrom
add-npm-workspace

Conversation

@salvador-barboza
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings May 6, 2025 23:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the local file reference for @github/spark with a published version and configures an npm workspace; it also updates the devcontainer setup script to install spark-tools into the new workspace layout.

  • Swapped @github/spark from file:../spark-tools to version 0.0.1 and added a workspaces block in package.json
  • Updated .devcontainer/onCreate.sh to move the extracted spark-tools into packages/spark-tools under the workspace

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Updated @github/spark dependency and added workspaces config
.devcontainer/onCreate.sh Changed install path to /workspaces/spark-template/packages/spark-tools

"typescript-eslint": "^8.25.0",
"vite": "^6.2.0"
},
"workspaces": {
Copy link

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using workspaces in package.json requires setting "private": true at the root, otherwise npm will prevent installation. Please add "private": true alongside your workspace config.

Copilot uses AI. Check for mistakes.
Comment on lines +41 to +42
mkdir -p /workspaces/spark-template/packages/spark-tools
sudo mv ./package/* /workspaces/spark-template/packages/spark-tools
Copy link

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Hardcoding the workspace path with the repository name (spark-template) can break if the repo is renamed. Consider deriving the path dynamically (e.g., using $PWD or an environment variable) to improve portability.

Suggested change
mkdir -p /workspaces/spark-template/packages/spark-tools
sudo mv ./package/* /workspaces/spark-template/packages/spark-tools
mkdir -p "$PWD/packages/spark-tools"
sudo mv ./package/* "$PWD/packages/spark-tools"

Copilot uses AI. Check for mistakes.
@jasonrclark jasonrclark merged commit 6b91e2b into main May 6, 2025
6 checks passed
@jasonrclark jasonrclark deleted the add-npm-workspace branch May 6, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants