Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the local file reference for @github/spark with a published version and configures an npm workspace; it also updates the devcontainer setup script to install spark-tools into the new workspace layout.
- Swapped
@github/sparkfromfile:../spark-toolsto version0.0.1and added aworkspacesblock inpackage.json - Updated
.devcontainer/onCreate.shto move the extractedspark-toolsintopackages/spark-toolsunder the workspace
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updated @github/spark dependency and added workspaces config |
| .devcontainer/onCreate.sh | Changed install path to /workspaces/spark-template/packages/spark-tools |
| "typescript-eslint": "^8.25.0", | ||
| "vite": "^6.2.0" | ||
| }, | ||
| "workspaces": { |
There was a problem hiding this comment.
Using workspaces in package.json requires setting "private": true at the root, otherwise npm will prevent installation. Please add "private": true alongside your workspace config.
| mkdir -p /workspaces/spark-template/packages/spark-tools | ||
| sudo mv ./package/* /workspaces/spark-template/packages/spark-tools |
There was a problem hiding this comment.
[nitpick] Hardcoding the workspace path with the repository name (spark-template) can break if the repo is renamed. Consider deriving the path dynamically (e.g., using $PWD or an environment variable) to improve portability.
| mkdir -p /workspaces/spark-template/packages/spark-tools | |
| sudo mv ./package/* /workspaces/spark-template/packages/spark-tools | |
| mkdir -p "$PWD/packages/spark-tools" | |
| sudo mv ./package/* "$PWD/packages/spark-tools" |
No description provided.