Skip to content

Fix for move on spark-tools#18

Merged
jasonrclark merged 1 commit intomainfrom
jasonrclark/fix-spark-tools-path
May 6, 2025
Merged

Fix for move on spark-tools#18
jasonrclark merged 1 commit intomainfrom
jasonrclark/fix-spark-tools-path

Conversation

@jasonrclark
Copy link
Copy Markdown
Member

@jasonrclark jasonrclark commented May 6, 2025

Copilot AI review requested due to automatic review settings May 6, 2025 23:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Streamline the dependency installation process by removing separate installs for spark-tools and consolidating to a single npm i in the spark-template directory.

  • Remove explicit cd and npm i in /workspaces/spark-tools
  • Drop the force-install flag for spark-tools from spark-template
  • Simplify to one npm i call at the end of the script
Comments suppressed due to low confidence (1)

.devcontainer/onCreate.sh:51

  • Removing the separate npm install for spark-tools may skip installing its dependencies if that package isn’t included in an npm workspaces config. Consider adding a workspace configuration in the root package.json or reinstating an explicit install step.
cd /workspaces/spark-tools

@jasonrclark jasonrclark merged commit 75c9d64 into main May 6, 2025
6 checks passed
@jasonrclark jasonrclark deleted the jasonrclark/fix-spark-tools-path branch May 6, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants