Update onCreate.sh to copy deploy script#25
Merged
alexagillman merged 1 commit intomainfrom May 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds the deploy.sh script to the container setup so it’s moved into /usr/local/bin alongside the other SDK tools.
- Includes
deploy.shin the post-create move steps - Keeps naming and placement consistent with existing utility scripts
Comments suppressed due to low confidence (1)
.devcontainer/onCreate.sh:34
- [nitpick] To align with the
spark-prefix used by other tools (e.g.,spark-server), consider renaming this tospark-deploy.shor dropping the.shextension for consistency.
sudo mv ./spark-sdk-dist/deploy.sh /usr/local/bin/deploy.sh
| sudo mv ./spark-sdk-dist/server.js /usr/local/bin/spark-server | ||
| sudo mv ./spark-sdk-dist/designer.js /usr/local/bin/spark-designer | ||
| sudo mv ./spark-sdk-dist/upload-to-remote.sh /usr/local/bin/upload-to-remote.sh | ||
| sudo mv ./spark-sdk-dist/deploy.sh /usr/local/bin/deploy.sh |
There was a problem hiding this comment.
After moving the script, ensure it’s executable by adding a chmod +x step, for example:
sudo mv ./spark-sdk-dist/deploy.sh /usr/local/bin/deploy.sh
sudo chmod +x /usr/local/bin/deploy.sh
Suggested change
| sudo mv ./spark-sdk-dist/deploy.sh /usr/local/bin/deploy.sh | |
| sudo mv ./spark-sdk-dist/deploy.sh /usr/local/bin/deploy.sh | |
| sudo chmod +x /usr/local/bin/deploy.sh |
salvador-barboza
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For item: https://github.com/github/spark/issues/1449