Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 3 additions & 34 deletions pkg/leeway/gotest_trace.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,9 @@ func (t *GoTestTracer) handleEvent(event *goTestEvent) {
switch event.Action {
case "run":
t.handleRun(event)
case "pause":
t.handlePause(event)
case "cont":
t.handleCont(event)
case "pause", "cont":
// Intentionally dropped: these events generate high-volume spans
// (test.paused/test.continued) with no diagnostic value.
case "pass", "fail", "skip":
t.handleEnd(event)
case "output":
Expand Down Expand Up @@ -205,36 +204,6 @@ func (t *GoTestTracer) handlePackageStart(event *goTestEvent) {
t.spans[key] = &testSpanData{span: span}
}

// handlePause records that a test was paused (for t.Parallel())
func (t *GoTestTracer) handlePause(event *goTestEvent) {
if event.Test == "" {
return
}

t.mu.Lock()
defer t.mu.Unlock()

key := spanKey(event.Package, event.Test)
if data, ok := t.spans[key]; ok {
data.span.AddEvent("test.paused", trace.WithTimestamp(event.Time))
}
}

// handleCont records that a paused test continued
func (t *GoTestTracer) handleCont(event *goTestEvent) {
if event.Test == "" {
return
}

t.mu.Lock()
defer t.mu.Unlock()

key := spanKey(event.Package, event.Test)
if data, ok := t.spans[key]; ok {
data.span.AddEvent("test.continued", trace.WithTimestamp(event.Time))
}
}

// handleEnd ends a span for a completed test
func (t *GoTestTracer) handleEnd(event *goTestEvent) {
t.mu.Lock()
Expand Down
15 changes: 7 additions & 8 deletions pkg/leeway/gotest_trace_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,13 @@ func TestGoTestTracer_ParallelTests(t *testing.T) {
t.Fatal("TestParallel span not found")
}

// Verify pause and cont events were recorded
eventNames := make([]string, 0)
for _, e := range testSpan.Events {
eventNames = append(eventNames, e.Name)
}

if len(eventNames) != 2 {
t.Errorf("expected 2 events (pause, cont), got %d: %v", len(eventNames), eventNames)
// Verify pause and cont events are NOT recorded (dropped to reduce span volume)
if len(testSpan.Events) != 0 {
eventNames := make([]string, 0, len(testSpan.Events))
for _, e := range testSpan.Events {
eventNames = append(eventNames, e.Name)
}
t.Errorf("expected 0 events (pause/cont dropped), got %d: %v", len(testSpan.Events), eventNames)
}
}

Expand Down
Loading