[pull] main from Homebrew:main#1236
Merged
Merged
Conversation
`:monkey` is CycloneDX's value for runtime modification, which a source-level `patch do` block cannot express, so omit it from the DSL.
…oneDX link Swap the libtool/Big Sur example for unzip per review: the libtool fix is technically a backport of upstream libtool applied to third-party tarballs, which muddies the :unofficial definition. unzip's Debian-maintained patches against a dormant upstream are a cleaner example. Add a note that :unofficial patches should be reported upstream, linking to the existing guidance in the Patches section. Drop the #components_items_pedigree_patches fragment from the CycloneDX link; the page is a JS-rendered schema viewer and html-proofer cannot find the anchor in the static HTML.
When a dependency's soname bumps and the old dylib is removed, an installed formula's binaries can be left linking against a library that no longer exists, aborting at load time with a dyld error. Surface this in the `brew info` Dependencies section for installed formulae as a "Missing libraries" line, marking each library with a red ✘ like other dependency statuses. The fix suggestion is `brew upgrade` when the formula is outdated (which also relinks it) and `brew reinstall` otherwise. The libraries are read from the existing LinkageChecker, combining broken dependencies (dylibs under opt/<dep>/) and broken dylibs that map to no dependency.
Add one more path helper similar to `formula_opt_(bin|lib|libexec|prefix)`. Adding it for consistency with other path methods Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
…warning Warn about missing libraries in brew info
utils/path: add `formula_opt_include` helper
`brew bundle` subcommands were not dispatching the user's `--quiet` flag to them, so inside a given subcommand quiet was always false. This resulted in log output always being printed regardless of user flags. I've added an integration test for `brew bundle check --quiet` specifically, which is how I had encountered this behavior.
…commands Forward the `--quiet` flag to all `brew bundle` subcommands
patch: add type and resolves DSL for annotating patches
- Make service blocks share the public formula path helpers used by Formula and Cask DSLs. - Allow core formulae to use bare helpers in service definitions under stable syntax checks.
Support path helpers in services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )