Skip to content

[pull] main from Homebrew:main #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Jun 25, 2026
+10 −1
Merged

[pull] main from Homebrew:main #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd6e5c0
Disable tap Git credential prompts
MikeMcQuaid Jun 24, 2026
988a7ca
Merge pull request #22869 from Homebrew/fix-tap-git-terminal-prompt
MikeMcQuaid Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Library/Homebrew/tap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ def apply_redirected_remote!(redirected_remote, quiet: false)
def git_command!(args, chdir: nil)
require "system_command"

SystemCommand.run!("git", args:, chdir:, print_stderr: true)
SystemCommand.run!("git", args:, chdir:, env: { "GIT_TERMINAL_PROMPT" => "0" }, print_stderr: true)
end
private :git_command!

Expand Down
9 changes: 9 additions & 0 deletions Library/Homebrew/test/tap_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,15 @@ def setup_completion(link:)
end

describe "#install" do
it "disables terminal prompts for git commands" do
require "system_command"

expect(SystemCommand).to receive(:run!)
.with("git", args: %w[fetch], chdir: path, env: { "GIT_TERMINAL_PROMPT" => "0" }, print_stderr: true)

homebrew_foo_tap.send(:git_command!, %w[fetch], chdir: path)
end

it "raises an error when the Tap is already tapped" do
setup_git_repo
already_tapped_tap = described_class.fetch("Homebrew", "foo")
Expand Down