feat: render TUI on /dev/tty for Helix and other editor embedding#2925
Open
leno23 wants to merge 2 commits into
Open
feat: render TUI on /dev/tty for Helix and other editor embedding#2925leno23 wants to merge 2 commits into
leno23 wants to merge 2 commits into
Conversation
When stdout is not a terminal (e.g. Helix :insert-output), use /dev/tty on Unix so gitui can run interactively. Add --tty to force this behavior. Fixes gitui-org#2556 Co-authored-by: Cursor <cursoragent@cursor.com>
Return an error if --tty is set but /dev/tty is unavailable (e.g. macOS permissions). Add unit tests for terminal_io. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Pushed a follow-up: Note: the CI workflow shows action_required for this fork PR — a maintainer may need to approve running workflows on the first contribution from this fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2556.
Helix
:insert-outputcaptures stdout, so gitui could not open its TUI. This change:/dev/ttyfor rendering (covers Helix withoutgitui >/dev/ttyin the keymap).--ttyto force/dev/ttyon Unix (documented in--help).TerminalWriter.Windows:
--ttyreturns an error; normal stdout behavior is unchanged.Helix usage
Test plan
cargo checkcargo test verify_appMade with Cursor