MALTAB reader added + SIZEOF issues fixed#1
Open
alirezamirian wants to merge 3 commits intogiuliopaci:masterfrom
Open
MALTAB reader added + SIZEOF issues fixed#1alirezamirian wants to merge 3 commits intogiuliopaci:masterfrom
alirezamirian wants to merge 3 commits intogiuliopaci:masterfrom
Conversation
All SIZEOFs had been changed to constant numbers to be consistent with what have been stated in documentation.
Replace all SIZEOFs with constant numbers in order to be consistent with documentation.
Matlab Spro file reader.
|
The explanation sounds good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In documentations we have:
"The compulsory fixed length header is a 10 byte binary header containing the feature vector dimension(5) (unsigned short = 2 bytes), a flag describing the content of the feature vector (long = 4 bytes) and the frame rate in Hz (float = 4 bytes)"
which is not consistent with implementation. SIZEOF_LONG is not 4 in all platforms and causes header to be not consistent with documentation. If header is to be "fixed length", no platform dependent sizeof instruction should be used.