fix(hsl): keep alpha when constructing from an object#396
Open
xianjianlf2 wants to merge 1 commit into
Open
Conversation
`chroma({ h, s, l, a })` dropped the alpha channel and returned an
opaque color, while the equivalent rgb object form kept it. hsl2rgb
already preserves alpha for array/positional input via its
`args.length > 3` branch, but unpacked objects with the keyOrder
`'hsl'`, which excludes the `a` key. Unpack with `'hsla'` (the same
keyOrder css/hsl2css.js already uses) so object input reaches the
existing alpha-preserving path. Array and positional callers are
unaffected since unpack ignores keyOrder when given 3+ args or an array.
Closes gka#219
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
chroma({ h, s, l, a })dropped the alpha channel and returned an opaque color, while the equivalent rgb object form kept it.hsl2rgbalready preserves alpha for array/positional input via itsargs.length > 3branch, but it unpacked objects with the keyOrder'hsl', which excludes theakey.Fix
Unpack with
'hsla'(the same keyOrdercss/hsl2css.jsalready uses) so object input reaches the existing alpha-preserving path. Array and positional callers are unaffected sinceunpackignores keyOrder when given 3+ args or an array.Testing
Added a regression test in
test/alpha.test.js:Closes #219