Skip to content

change to get useid from role list #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CoraBlack merged 1 commit into from
Apr 13, 2026
Merged

change to get useid from role list #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions .github/workflows/pr-to-feishu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
FEISHU_APP_ID: ${{ secrets.FEISHU_APP_ID }}
FEISHU_APP_SECRET: ${{ secrets.FEISHU_APP_SECRET }}
FEISHU_WEBHOOK_URL: ${{ secrets.FEISHU_WEBHOOK_URL }}
FEISHU_CODE_REVIEWER_GROUP_ID: ${{ secrets.FEISHU_CODE_REVIEWER_GROUP_ID }}
FEISHU_CODE_REVIEWER_ROLE_ID: ${{ secrets.FEISHU_CODE_REVIEWER_ROLE_ID }}
with:
script: |
const pr = context.payload.pull_request
Expand All @@ -35,7 +35,7 @@ jobs:
'FEISHU_APP_ID',
'FEISHU_APP_SECRET',
'FEISHU_WEBHOOK_URL',
'FEISHU_CODE_REVIEWER_GROUP_ID'
'FEISHU_CODE_REVIEWER_ROLE_ID'
]

for (const key of requiredSecrets) {
Expand Down Expand Up @@ -80,15 +80,14 @@ jobs:
return token
}

async function listGroupMembersOpenId(tenantToken) {
async function listRoleMembersOpenId(tenantToken) {
const members = []
let pageToken = ''

while (true) {
const url = new URL(`https://open.feishu.cn/open-apis/contact/v3/group/${encodeURIComponent(process.env.FEISHU_CODE_REVIEWER_GROUP_ID)}/member/simplelist`)
url.searchParams.set('page_size', '50')
url.searchParams.set('member_id_type', 'open_id')
url.searchParams.set('member_type', 'user')
const url = new URL(`https://open.feishu.cn/open-apis/contact/v3/functional_roles/${encodeURIComponent(process.env.FEISHU_CODE_REVIEWER_ROLE_ID)}/members`)
url.searchParams.set('page_size', '100')
url.searchParams.set('user_id_type', 'open_id')
if (pageToken) {
url.searchParams.set('page_token', pageToken)
}
Expand All @@ -101,10 +100,10 @@ jobs:
}
})

const list = data?.data?.memberlist || []
const list = data?.data?.members || []
for (const member of list) {
if (member?.member_type === 'user' && member?.member_id) {
members.push(member.member_id)
if (member?.user_id) {
members.push(member.user_id)
}
}

Expand Down Expand Up @@ -160,18 +159,18 @@ jobs:
const tenantToken = await getTenantToken()
core.setSecret(tenantToken)

const reviewerOpenIds = await listGroupMembersOpenId(tenantToken)
const reviewerOpenIds = await listRoleMembersOpenId(tenantToken)
if (reviewerOpenIds.length === 0) {
await notifyWebhook([
'GitHub 有新的 PR，但未查询到 code_reviewer 用户组成员：',
'GitHub 有新的 PR，但未查询到 code_reviewer 角色成员：',
`- 事件: ${context.payload.action}`,
`- 标题: ${pr.title}`,
`- 链接: ${pr.html_url}`,
`- Contributor: ${pr.user?.login || 'unknown'}`,
`- 编号: #${pr.number}`,
`- 用户组ID: ${process.env.FEISHU_CODE_REVIEWER_GROUP_ID}`
`- 角色ID: ${process.env.FEISHU_CODE_REVIEWER_ROLE_ID}`
].join('\n'))
core.info('No members found in reviewer group; sent fallback notification.')
core.info('No members found in reviewer role; sent fallback notification.')
return
}

Expand Down
Loading