Develop vector2、constants and scalar.#43
Open
YuanSang0512 wants to merge 2 commits intogkit-org:mainfrom
Open
Conversation
CoraBlack
requested changes
Apr 15, 2026
| float x = 0.f, | ||
| y = 0.f; | ||
|
|
||
| inline constexpr auto length() const -> float32 { return std::sqrt(x * x + y * y); } |
Contributor
There was a problem hiding this comment.
msvc中，std::sqrt 是非 constexpr 函数。在gcc/llvm平台是constexpr的（但这并非标准cpp20标准，cpp23才支持正式的编译期 std::sqrt ）
CoraBlack
requested changes
Apr 16, 2026
…ix some small problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.