Skip to content

remove duplicate detection codes#434

Merged
ludwiglierhammer merged 7 commits into
glamod:mainfrom
ludwiglierhammer:no_dup_detect
Jun 25, 2026
Merged

remove duplicate detection codes#434
ludwiglierhammer merged 7 commits into
glamod:mainfrom
ludwiglierhammer:no_dup_detect

Conversation

@ludwiglierhammer

@ludwiglierhammer ludwiglierhammer commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • delete duplicate detection from this module

Does this PR introduce a breaking change?

  • cdm_reader_mapper.DupDetect not importable anymore

  • cdm_reader_mapper.duplicate_check not importable anymore

  • cdm_reader_mapper.DataBundle does not support:

    • duplicate_check()
    • get_duplicates()
    • flag_duplicates()
    • remove_duplicates()
  • cdm_reader_mapper.DataBundle does not have attribute DupDetect

Other information:

The duplicate checker is moved to marine_qc (see glamod/marine_qc#207).

@ludwiglierhammer ludwiglierhammer merged commit 1f10c8d into glamod:main Jun 25, 2026
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Outsourcing of the duplicate checker Cross-referring duplicates

1 participant