Skip to content

string goes object#435

Merged
ludwiglierhammer merged 15 commits into
glamod:mainfrom
ludwiglierhammer:str_dtype
Jun 25, 2026
Merged

string goes object#435
ludwiglierhammer merged 15 commits into
glamod:mainfrom
ludwiglierhammer:str_dtype

Conversation

@ludwiglierhammer

@ludwiglierhammer ludwiglierhammer commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes no current issue
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • adapt to new pandas version (>=3.0.0) that makes huge differences between string and object types.

Does this PR introduce a breaking change?

  • reader functions return object types instead of string types

Other information:

@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.05%. Comparing base (98ad9c4) to head (0e1caf4).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   96.69%   97.05%   +0.35%     
==========================================
  Files          80       78       -2     
  Lines        3817     3496     -321     
==========================================
- Hits         3691     3393     -298     
+ Misses        126      103      -23     
Flag Coverage Δ
unittests 97.05% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ludwiglierhammer ludwiglierhammer merged commit deac901 into glamod:main Jun 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants