test: cover updater error parity#86
Closed
travis-hoover-glean wants to merge 1 commit into
Closed
Conversation
david-hamilton-glean
approved these changes
Jun 5, 2026
|
|
||
| describe('checkForUpdate error behavior', () => { | ||
| it('throws when version metadata omits version', async () => { | ||
| ;(fetch as Mock).mockResolvedValueOnce(okJson({})) |
Member
There was a problem hiding this comment.
1/5 (nit, non-blocking)
what's with the leading ; in these test bodies?
| }) | ||
|
|
||
| it('returns false and does not re-exec when replacing a renamed Windows binary fails', async () => { | ||
| ;(fetch as Mock).mockResolvedValueOnce(okJson({ version: '9.9.9' })).mockResolvedValueOnce(okBinary()) |
Member
There was a problem hiding this comment.
1/5 (nit, non-blocking)
we have a whole block of mocks at the top of this file to avoid all this typecasting in test bodies. Consider adding a mockFetch there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds TypeScript characterization tests for updater edge cases: malformed version metadata and Windows install failures should not re-exec after a failed replacement/pending write.\n\nTested: npm test -- --run src/updater.spec.ts