Skip to content

test: cover URL property precedence #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
travis-hoover-glean wants to merge 1 commit into from
Closed

test: cover URL property precedence #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/hosts/json-configurator.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,41 @@ describe('configureJsonFile', () => {
})
})

it('uses registry URL-property order when an entry has multiple URL-like fields', () => {
const filePath = join(tempDir, 'mcp.json')
writeFileSync(
filePath,
JSON.stringify({
mcpServers: {
mixed_existing: {
url: 'https://example-be.glean.com/mcp/default',
httpUrl: 'https://other-be.glean.com/mcp/default',
},
},
}),
)

configureJsonFile({
configToMerge: {
mcpServers: {
incoming_same_url: {
url: 'https://example-be.glean.com/mcp/default',
},
},
},
filePath,
})

const result = JSON.parse(readFileSync(filePath, 'utf-8'))

expect(result.mcpServers).toEqual({
mixed_existing: {
url: 'https://example-be.glean.com/mcp/default',
httpUrl: 'https://other-be.glean.com/mcp/default',
},
})
})

it('deduplicates within incoming entries that share the same URL', () => {
const filePath = join(tempDir, 'mcp.json')

Expand Down