refactor: rename runtime env vars to CUTTLE_*; drop cuttleserve shim#6
Open
tenequm wants to merge 1 commit into
Open
refactor: rename runtime env vars to CUTTLE_*; drop cuttleserve shim#6tenequm wants to merge 1 commit into
tenequm wants to merge 1 commit into
Conversation
The env-var contract and the container entrypoint carried leftover names from the upstream cloakserve/cloakbrowser project (a mechanical s/cloak/ cuttle/ that kept the meaningless 'serve' infix, plus one CLOAKSERVE_ that was never renamed). All producers and consumers are in-repo, so rename to a clean CUTTLE_* namespace: CUTTLESERVE_PROXY -> CUTTLE_PROXY CUTTLESERVE_HOST -> CUTTLE_HOST CUTTLESERVE_EPHEMERAL -> CUTTLE_EPHEMERAL CLOAKSERVE_IDLE_TIMEOUT-> CUTTLE_IDLE_TIMEOUT CLOAKBROWSER_BINARY_PATH -> CUTTLE_BROWSER_BINARY Also drop the cuttleserve compatibility shim: the host CLI now invokes 'cuttle serve' directly and the image CMD is 'cuttle serve', removing the self-referential shim script the Dockerfile carried only to satisfy the CLI's own hardcoded 'cuttleserve' command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two cloakserve/cloakbrowser leftovers survived the earlier attribution scrub because that pass targeted branding text, not functional identifiers. Both are self-inflicted and fully in-repo, so this cleans them up.
1. Env-var contract -> clean
CUTTLE_*namespaceThe names were a mechanical
s/cloak/cuttle/that kept the meaninglessserveinfix, and one that was never renamed at all (CLOAKSERVE_IDLE_TIMEOUT):CUTTLESERVE_PROXYCUTTLE_PROXYCUTTLESERVE_HOSTCUTTLE_HOSTCUTTLESERVE_EPHEMERALCUTTLE_EPHEMERALCLOAKSERVE_IDLE_TIMEOUTCUTTLE_IDLE_TIMEOUTCLOAKBROWSER_BINARY_PATHCUTTLE_BROWSER_BINARY2. Drop the
cuttleserveshimThe Dockerfile carried a shim script (
exec cuttle serve "$@") that existed only because the host CLI hardcodedserveCommand = "cuttleserve"as the container command. The CLI now invokescuttle servedirectly and the imageCMDiscuttle serve, so the shim is gone.Blast radius
Every producer/consumer is inside this repo (host CLI, serve daemon, fingerprint pkg, Dockerfile, helm chart, docs). The image is version-pinned by the CLI default, so a new image only ever pairs with a matching CLI. No golden regen needed.
Verification
just check- 176 tests pass, lint + fmt cleanjust build-image(cuttle:local) - CMD baked as["cuttle","serve","--headless=false"],CUTTLE_BROWSER_BINARY=/opt/clark/chromecuttle up/status/downlifecycle green; CDP up (Chrome/148.0.7778.96, clark engine via the new env var)cuttleserve: not found, exactly as the version pin intends.