Use std::array to reduce allocations in ManagedArray::operator()#1429
Open
janbridley wants to merge 5 commits into
Open
Use std::array to reduce allocations in ManagedArray::operator()#1429janbridley wants to merge 5 commits into
janbridley wants to merge 5 commits into
Conversation
4 tasks
janbridley
changed the title
janbridley
marked this pull request as ready for review
May 8, 2026 01:08
…to feat/remove-allocation-from-managedarray-index
joaander
reviewed
May 8, 2026
joaander
left a comment
joaander
left a comment
Member
There was a problem hiding this comment.
Thanks! This one also needs a change log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As noted in a now-removed comment, the use of std::vector in operator() for managed arrays could be a performance bottleneck. This was particularly obvious in order/Nematic, but is also true of SolidLiquid and probably other OPs. This fix retains the original vector indexing where needed, but defaults to std::array for allocation-free indexing.
Motivation and Context
Resolves: #???
How Has This Been Tested?
Checklist: