Update AttachExtended Project to be compatible with Attach project latest (4.0.22-SNAPSHOT)#12
Open
ctoabidmaqbool wants to merge 1 commit intogluonhq:masterfrom
Open
Conversation
ctoabidmaqbool
commented
Dec 5, 2024
- Aligned AttachExtended version with Attach becase, AttachExtended project is just like duplicate copy having custome implmentation for user's plugins and it's dependent upon Attach -> Util plugin!
- Try to update structure and libs of Attach project;
…test (4.0.22-SNAPSHOT). Aligned AttachExtended version e.g. 4.0.22-SNAPSHOT with Attach Project.
Author
|
@jperedadnr @abhinayagarwal @johanvos! |
Collaborator
|
Thanks for your PR. AttachExtended is a playground repo, it is more like a demo/tutorial for people to understand how to create their own custom Attach service, and doesn't need to be up to date all the time. We are not against keeping up to date, though. However, it doesn't make sense to update it now with a snapshot of Attach. Let's just wait until we release Attach 4.0.22. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.