fix(flow-next): check depends_on_epics in cmd_ready#95
Open
possibilities wants to merge 1 commit intogmickel:mainfrom
Open
fix(flow-next): check depends_on_epics in cmd_ready#95possibilities wants to merge 1 commit intogmickel:mainfrom
possibilities wants to merge 1 commit intogmickel:mainfrom
Conversation
cmd_ready only checked task-level depends_on when determining which tasks are ready. It ignored the epic's own depends_on_epics field, so tasks in blocked epics were reported as ready to work on. cmd_next already handles this correctly (lines 4425-4441) by filtering out epics whose depends_on_epics aren't all done. This adds the same gate to cmd_ready: if the epic is blocked by unfinished prerequisite epics, return empty ready/in_progress/blocked lists with a new epic_blocked_by field in JSON output. The bug is latent in flow-next's default workflow because Ralph uses next exclusively and flow-next-work only calls ready on pre-validated epics. External consumers that call ready per-epic independently hit it immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, really enjoying this project, thanks for making it and making it public (also huge compliments on your website!). If you're interested I made this patch for an issue I ran into.
I use flowctl's CLI commands directly rather than through Ralph/flow-next-work. The
readycommand doesn't checkdepends_on_epics, so blocked epics report their tasks as ready.nextalready has this check — this patch adds the same gate toready.With epics fn-1 → fn-2 (
depends_on_epics), fn-1 not done:flowctl ready --epic fn-2returns root tasks as readyepic_blocked_by: [fn-1]Anyway, thanks for everything. This is what the robots are saying about it: