Add proper status handling and conditions#87
Merged
Conversation
Deploying gnmic-operator with
|
| Latest commit: |
620ba80
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ac490f2c.gnmic-operator2.pages.dev |
| Branch Preview URL: | https://feature-status-updates.gnmic-operator2.pages.dev |
Introduce a StatusUpdater interface and k8s-backed implementation so the discovery pipeline reports lifecycle conditions (Reconciling, Ready, Stalled) alongside the target count and last-sync timestamp. - add core.StatusUpdater + core.StatusUpdate and k8sStatusUpdater client - add Conditions field to TargetSourceStatus (regenerated deepcopy + CRD) - thread the updater through CommonLoaderConfig, the HTTP loader, and the message processor; wire it in targetsource_controller - drop the now-superseded updateTargetSourceStatus helper Reworked from #87 onto current main: drops that branch's duplicated resource-fetcher and stale pre-#63 pull-loader, keeping only the status handling. Co-authored-by: Cursor <cursoragent@cursor.com>
karimra
force-pushed
the
feature/status-updates
branch
from
3246ecd to
620ba80
Compare
karimra
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatusUpdaterinterfaceDiscoveryKubernetesClientimplements this interface